Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to not flush stream buffers on every message send #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tigerquoll
Copy link

Provides feature requested in #49

Adds a property to TcpSyslogMessageSender, "SocketFlush", with getters and setters:
Accepted values:

  • SocketFlush.onSend - Default value - continues existing behaviour of flushing at every send, to ensure that all data is passed to the syslog server.
  • SocketFlush.onClose -New behaviour to only flush stream buffers on syslog client close. This is higher performance but risks a small amount dataloss if the syslog server reboots.

@tigerquoll
Copy link
Author

@cyrille-leclerc, could I ping you for a review please?

@cyrille-leclerc
Copy link
Contributor

@tigerquoll I'm sorry but I lost access to this repository 2 years ago when I left CloudBees.
@bwalding can someone from CloudBees help clarify the future of this library?

@lemeurherve
Copy link
Member

@cyrille-leclerc @tigerquoll FYI, a thread has been started on the jenkinsci-dev mailing list:
[Proposal] Transfer of CloudBees-community/syslog-java-client to jenkinsci Github org

@basil
Copy link
Member

basil commented Mar 14, 2022

Hi @cyrille-leclerc, gentle friendly ping: if you would like access to this repository, please respond in the mailing list thread. If not, no problem! If nobody claims this repository within two weeks, then I will adopt it as interim maintainer to complete the transfer to the jenkinsci GitHub organization, but I cannot promise timely review, merge, or release of the PR backlog.

@cyrille-leclerc
Copy link
Contributor

I'm back from PTO. I replied to the mailing list thread to support this proposal https://groups.google.com/g/jenkinsci-dev/c/ZmNbkgCadUY/m/NvvT4axhAAAJ

@tigerquoll
Copy link
Author

Hi @cyrille-leclerc, are you still able to review?

@cyrille-leclerc
Copy link
Contributor

@tigerquoll I'm sorry but I'm no longer an active maintainer of this library and I don't have much time at the moment.
@basil @lemeurherve could someone from the Jenkins community review this PR?

@lemeurherve
Copy link
Member

lemeurherve commented Jun 3, 2022

I'm not a plugin maintainer, not sure my review would add a lot.

@cyrille-leclerc WDYT of adding the adopt-this-plugin tag to this repository?
@tigerquoll WDTY of adopting this plugin? Ref: https://www.jenkins.io/doc/developer/plugin-governance/adopt-a-plugin/

@cyrille-leclerc
Copy link
Contributor

@lemeurherve I would love to make this library open for adoption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants